fix(types): build types from JS source #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
force-pushed
the
build-types
branch
5 times, most recently
from
5643c59
to
5192455
Compare
mcous
commented
May 31, 2024
mcous
commented
May 31, 2024
mcous
force-pushed
the
build-types
branch
2 times, most recently
from
22bd3d5
to
2fcc251
Compare
mcous
force-pushed
the
testing-core-mod
branch
2 times, most recently
from
70f6d81
to
18b118b
Compare
mcous
force-pushed
the
testing-core-mod
branch
3 times, most recently
from
ba6f67f
to
6533bb3
Compare
mcous
force-pushed
the
build-types
branch
2 times, most recently
from
979431a
to
a2a5039
Compare
mcous
force-pushed
the
build-types
branch
3 times, most recently
from
5df1128
to
06644b9
Compare
mcous
changed the title
|
🎉 This PR is included in version 5.2.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR moves the source of truth for typing from a separately maintained
types/index.d.tsfile to JSDoc comments insrc. I'm hopeful this will ease the maintenance burden of types, especially as we're supporting three major versions of Svelte.Svelte itself is undergoing some major-ish typing changes, so I'm keeping this as a draft for now
Change log
types/index.d.tstosrc/**tscandenableJsFuture work
For now, I think vanilla JS is the best fit for this project, so I don't see any compelling reason to do anything drastic like switch to TS and introduce a build step. That being said, I do see this as a potential first step in introducing type-checking to the codebase via TS's
checkJsoption