Support empty string for maxlength #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An input's maxlength can be an empty string, which should NOT limit typing.
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 857 862 +5
Branches 325 327 +2
=========================================
+ Hits 857 862 +5
Continue to review full report at Codecov.
|
ph-fritsche
requested changes
Mar 18, 2021
fix: sanitize maxLength attribute
ph-fritsche
approved these changes
Mar 18, 2021
|
🎉 This PR is included in version 13.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Mar 18, 2021
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
An input's maxlength can be an empty string, which should NOT limit typing.
Why:
Browsers work that way.
How:
Use||instead of??operator to convert "" into -1 instead of 0.ph-fritsche introduced a new function
getSanitizedMaxLengthto handle multiple edge casesChecklist: