feat(base-cluster/rbac)!: allow to use the k8s default ClusterRoles #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most often used rbac roles are exactly the default ones, this eases that configuration this is breaking because one might already use these names, but they are now forbidden
cwrau
requested review from
marvinWolff,
tasches and
teutonet-bot
as code owners
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
tasches
approved these changes
Nov 11, 2024
cwrau
deleted the
feat/base-cluster/allow-to-use-the-default-clusterroles
branch
teutonet-bot
added a commit
that referenced
this pull request
Nov 11, 2024
🤖 I have created a release *beep* *boop* --- ## [7.0.0](base-cluster-v6.7.0...base-cluster-v7.0.0) (2024-11-11) ### ⚠ BREAKING CHANGES * **base-cluster/rbac:** allow to use the k8s default ClusterRoles ([#1230](#1230)) * **base-cluster/dependencies:** update helm release descheduler to 0.31.x ([#1173](#1173)) ### Features * **base-cluster/rbac:** allow to use the k8s default ClusterRoles ([#1230](#1230)) ([a3b24e4](a3b24e4)) ### Bug Fixes * **base-cluster/monitoring:** only roll out alertmanager oauth-proxy when alertmanager is enabled 🤣 ([#1180](#1180)) ([a1d8888](a1d8888)) * **base-cluster:** curl images imagePullPolicy ([#1168](#1168)) ([bb1942d](bb1942d)) ### Miscellaneous Chores * **base-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.31.2 ([#1191](#1191)) ([e3ffc13](e3ffc13)) * **base-cluster/dependencies:** update docker.io/curlimages/curl docker tag to v8.10.1 ([#1193](#1193)) ([54966a8](54966a8)) * **base-cluster/dependencies:** update docker.io/fluxcd/flux-cli docker tag to v2.4.0 ([#1212](#1212)) ([6519edf](6519edf)) * **base-cluster/dependencies:** update helm release descheduler to 0.31.x ([#1173](#1173)) ([784958c](784958c)) * **base-cluster/dependencies:** update helm release kube-prometheus-stack to v65 ([#1214](#1214)) ([5f701ed](5f701ed)) * **base-cluster:** formatting ([#1198](#1198)) ([b9bd4a4](b9bd4a4)) * **base-cluster:** this is now supported 🥳 ([#1135](#1135)) ([515ce2d](515ce2d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most often used rbac roles are exactly the default ones, this eases
that configuration
this is breaking because one might already use these names, but they are
now forbidden