Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using sys.exectuable instead of hardcoded 'python' in test command #38

Closed
arunpersaud opened this issue Nov 22, 2016 · 6 comments
Closed

Comments

@arunpersaud
Copy link

in tests/test_cli.py line 5

'python' is used inside a command, but for python3 installation, e.g. on openSUSE, this doesn't work, since python would be the 2.7 version. Perhaps sys.executable should be used here?

I ran into this issue while trying to package textile for openSUSE as a python3 package, not sure, if this is also used in other locations.

Arun

@sebix
Copy link
Member

sebix commented Nov 23, 2016

I ran into this issue while trying to package textile for openSUSE as a python3 package

It's already there: https://build.opensuse.org/package/show/devel:languages:python3/python3-textile

@ikirudennis
Copy link
Member

Is there any action required on my end? Is there anything I could or should do to simplify things?

@arunpersaud
Copy link
Author

@sebix: I know;) I'm part of devel:languages:python3 and working on updating the version in dlp3 to 2.3.6.
see https://build.opensuse.org/package/show/home:apersaud:branches:devel:languages:python3/python3-textile

@sebix
Copy link
Member

sebix commented Nov 24, 2016

I can push a fix, but this won't solve the problem. The textile module is not installed in standard paths in the build environment, so we can only import textile from the current directory, not the installed lib. This will work, but that's not the aim of the test.

@sebix
Copy link
Member

sebix commented Apr 1, 2017

In the build environment we can just remove this test I think.

Concerning the package for opensuse: I'm waiting for the singlespec of pytest, then I can finalize the singlespec package for textile.

@ikirudennis
Copy link
Member

Thanks once again, @sebix. This will be pushed to master and released soon-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants