This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Tweaks for the simpler auctioneer winner selection flow #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderpick
force-pushed
the
sander/auctioneer-v2
branch
from
e68fb11 to
0973909
Compare
Signed-off-by: Sander Pick <sanderpick@gmail.com>
sanderpick
force-pushed
the
sander/auctioneer-v2
branch
from
0973909 to
ae8a536
Compare
sanderpick
commented
Jul 30, 2021
| @@ -41,10 +41,9 @@ type Bid struct { | |||
|
|
|||
| // WinningBid contains details about a winning bid. | |||
| type WinningBid struct { | |||
| BidderID peer.ID | |||
| Acknowledged bool // Whether or not the bidder acknowledged receipt of the win | |||
There was a problem hiding this comment.
Acknowledged: No longer needed because winners that's don't ack they have won are not selected. This happens in-line during winner selection.ProposalCidAcknowledged: No longer needed because when winners don't ack the proposal cid delivery, an error is stored in the new fieldErrorCauseand returned to the broker. In this case, the broker would have to decide what to do. Most likely retrying and/or recreating the auction.
sanderpick
changed the title
merlinran
approved these changes
Aug 2, 2021
merlinran
reviewed
Aug 2, 2021
lib/auction/auction.go
Outdated
| @@ -41,10 +41,9 @@ type Bid struct { | |||
|
|
|||
| // WinningBid contains details about a winning bid. | |||
| type WinningBid struct { | |||
There was a problem hiding this comment.
Oh wait @sanderpick just realized that bidbot doesn't use this struct at all! We could simply move this altogether to the storage broker code to remove dependency - if you think it's okay.
There was a problem hiding this comment.
ah yeah, good point. I'll move it over to the other PR and update this one
Signed-off-by: Sander Pick <sanderpick@gmail.com>
|
Moved models to core... merging this one now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinningBidmodel (see below).