This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
mask more flags; print error loading config #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merlin Ran <merlinran@gmail.com>
merlinran
commented
Oct 13, 2021
| @@ -203,7 +203,8 @@ Zero means no limits`, | |||
| v.SetConfigName("config") | |||
| v.AddConfigPath(os.Getenv("BIDBOT_PATH")) | |||
| v.AddConfigPath(defaultConfigPath) | |||
| _ = v.ReadInConfig() | |||
| err := v.ReadInConfig() | |||
| cli.CheckErrf(fmt.Sprintf("loading config from %s: %%v", v.ConfigFileUsed()), err) | |||
There was a problem hiding this comment.
Without this bidbot prints a confusing message like this, if the config file format is invalid.
2021/10/13 21:14:39 --storage-provider-id is required. See ‘bidbot help init’ for instructions
| @@ -323,7 +324,7 @@ var daemonCmd = &cobra.Command{ | |||
| cli.CheckErrf("getting peer config: %v", err) | |||
|
|
|||
| settings, err := cli.MarshalConfig(v, !v.GetBool("log-json"), | |||
| "private-key", "wallet-addr-sig", "lotus-miner-api-token") | |||
| "cid-gravity-key", "private-key", "wallet-addr-sig", "lotus-miner-api-token", "lotus-market-api-token") | |||
There was a problem hiding this comment.
forgot to mask them. spotted by Julien.
jsign
approved these changes
Oct 13, 2021
| @@ -323,7 +324,7 @@ var daemonCmd = &cobra.Command{ | |||
| cli.CheckErrf("getting peer config: %v", err) | |||
|
|
|||
| settings, err := cli.MarshalConfig(v, !v.GetBool("log-json"), | |||
| "private-key", "wallet-addr-sig", "lotus-miner-api-token") | |||
| "cid-gravity-key", "private-key", "wallet-addr-sig", "lotus-miner-api-token", "lotus-market-api-token") | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny changes but masking the tokens is important, so prob. worth a PR.