Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(players): store active game in player model #1099

Merged

Conversation

garrappachc
Copy link
Member

Instead of having it dynamic, store player's active game directly in player model.

@garrappachc garrappachc added the fix A fix to an issue label Jul 11, 2021
@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #1099 (9162e13) into master (81d1d19) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
+ Coverage   94.22%   94.25%   +0.02%     
==========================================
  Files         166      166              
  Lines        3378     3392      +14     
  Branches      320      341      +21     
==========================================
+ Hits         3183     3197      +14     
  Misses        188      188              
  Partials        7        7              
Impacted Files Coverage Δ
src/games/models/game-slot.ts 100.00% <100.00%> (ø)
src/games/services/game-event-handler.service.ts 91.17% <100.00%> (+0.40%) ⬆️
src/games/services/games.service.ts 74.48% <100.00%> (+0.80%) ⬆️
src/games/services/player-substitution.service.ts 97.47% <100.00%> (+0.02%) ⬆️
src/players/models/player.ts 100.00% <100.00%> (ø)
src/players/services/players.service.ts 98.03% <100.00%> (+0.10%) ⬆️
src/profile/controllers/profile.controller.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d1d19...9162e13. Read the comment docs.

@garrappachc garrappachc merged commit 18a0d94 into tf2pickup-org:master Jul 11, 2021
@garrappachc garrappachc deleted the store-active-game-in-player-model branch July 11, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix to an issue
Development

Successfully merging this pull request may close these issues.

1 participant