Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(games): serialize gameServer properly #1226

Merged

Conversation

garrappachc
Copy link
Member

No description provided.

@garrappachc garrappachc added the fix A fix to an issue label Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #1226 (99c1d9e) into master (7c43e2f) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
- Coverage   95.06%   94.90%   -0.17%     
==========================================
  Files         183      183              
  Lines        3669     3670       +1     
  Branches      332      332              
==========================================
- Hits         3488     3483       -5     
- Misses        179      185       +6     
  Partials        2        2              
Impacted Files Coverage Δ
src/games/models/game.ts 97.36% <0.00%> (-2.64%) ⬇️
src/games/services/rcon-factory.service.ts 33.33% <0.00%> (-55.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c43e2f...99c1d9e. Read the comment docs.

@garrappachc garrappachc merged commit 5b5c5ed into tf2pickup-org:master Sep 14, 2021
@garrappachc garrappachc deleted the fix-gameserver-serialization branch September 14, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix to an issue
Development

Successfully merging this pull request may close these issues.

1 participant