feat(game-servers): Improve available gameserver detection #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetroScript
force-pushed
the
improve-available-gameserver-detection
branch
from
9fa57bb
to
751ceab
Compare
|
We need to make sure not only the assigned game has ended, but also the gameserver it was running on got cleaned up. |
garrappachc
requested changes
Nov 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
===========================================
+ Coverage 83.48% 95.04% +11.55%
===========================================
Files 182 182
Lines 3652 3670 +18
Branches 328 334 +6
===========================================
+ Hits 3049 3488 +439
+ Misses 602 180 -422
- Partials 1 2 +1
Continue to review full report at Codecov.
|
This property is needed to ensure that the cleanup already happened of a server
garrappachc
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it happens, that a
game serverreferences agame, despite that game not running anymore.This PR improves the detection of available game servers. Instead if just checking if a game server has a game property, it also loads the game which is attached to the game server to confirm, that the game is still running.
If the game is not running anymore, the game server gets released and returned as available.
Additionally this PR adds a property
endedAtto theGamemodel. This is used to identify if a cleanup of a game is already finished.This PR only releases a game server, if the game state is ended or interrupted since at least two minutes.