Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(games): better game server clean up logic #1371

Merged

Conversation

garrappachc
Copy link
Member

No description provided.

@garrappachc garrappachc added the fix A fix to an issue label Nov 18, 2021
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #1371 (8d1cd57) into master (3982644) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1371   +/-   ##
=======================================
  Coverage   95.08%   95.09%           
=======================================
  Files         185      186    +1     
  Lines        3705     3708    +3     
  Branches      336      333    -3     
=======================================
+ Hits         3523     3526    +3     
  Misses        180      180           
  Partials        2        2           
Impacted Files Coverage Δ
src/game-servers/services/game-servers.service.ts 94.36% <100.00%> (-1.04%) ⬇️
src/games/games.module.ts 100.00% <100.00%> (ø)
src/games/services/game-event-handler.service.ts 95.83% <100.00%> (-0.12%) ⬇️
src/games/services/game-runtime.service.ts 90.27% <100.00%> (-0.52%) ⬇️
src/games/services/game-server-clean-up.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3982644...8d1cd57. Read the comment docs.

@garrappachc garrappachc merged commit 4397c06 into tf2pickup-org:master Nov 23, 2021
@garrappachc garrappachc deleted the better-game-server-clean-up-logic branch November 23, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix to an issue
Development

Successfully merging this pull request may close these issues.

1 participant