Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(games): cache voice channel url #2726

Merged

Conversation

garrappachc
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d595738) 92.47% compared to head (e4c31a4) 92.49%.

Files Patch % Lines
src/games/services/voice-channel-urls.service.ts 96.82% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2726      +/-   ##
==========================================
+ Coverage   92.47%   92.49%   +0.01%     
==========================================
  Files         303      304       +1     
  Lines        5851     5888      +37     
  Branches      608      611       +3     
==========================================
+ Hits         5411     5446      +35     
- Misses        425      428       +3     
+ Partials       15       14       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@garrappachc garrappachc merged commit d6daad0 into tf2pickup-org:master Jan 11, 2024
25 checks passed
@garrappachc garrappachc deleted the cache-voice-channel-urls branch January 11, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant