fix(players): ignore TF2 in-game hours verification failure when the …

…verification is not needed (#477)

src/players/services/players.service.spec.ts

@@ -15,6 +15,12 @@ import { SteamApiService } from './steam-api.service';
 import { DiscordService } from '@/discord/services/discord.service';
 import { ObjectId } from 'mongodb';
 
+jest.mock('@configs/players', () => ({
+  minimumTf2InGameHours: 500,
+  requireEtf2lAccount: true,
+}));
+import { minimumTf2InGameHours } from '@configs/players';
+
 jest.mock('@/discord/services/discord.service');
 
 class EnvironmentStub {
@@ -259,6 +265,22 @@ describe('PlayersService', () => {
       it('should deny', async () => {
         await expect(service.createPlayer(mockSteamProfile)).rejects.toThrowError('cannot verify in-game hours for TF2');
       });
+
+      describe('and nobody cares', () => {
+        beforeEach(() => {
+          // @ts-ignore
+          minimumTf2InGameHours = 0;
+        });
+
+        afterEach(() => {
+          // @ts-ignore
+          minimumTf2InGameHours = 500;
+        });
+
+        it('should pass', async () => {
+          await service.createPlayer(mockSteamProfile);
+        });
+      });
     });
   });
 

src/players/services/players.service.ts

@@ -58,10 +58,7 @@ export class PlayersService {
   }
 
   async createPlayer(steamProfile: SteamProfile): Promise<DocumentType<Player>> {
-    const hoursInTf2 = await this.steamApiService.getTf2InGameHours(steamProfile.id);
-    if (hoursInTf2 < minimumTf2InGameHours) {
-      throw new Error('not enough tf2 hours');
-    }
+    await this.verifyTf2InGameHours(steamProfile.id);
 
     let etf2lProfile: Etf2lProfile;
     let name = steamProfile.displayName;
@@ -178,4 +175,19 @@ export class PlayersService {
     return { player: playerId, gamesPlayed, classesPlayed };
   }
 
+  private async verifyTf2InGameHours(steamId: string) {
+    try {
+      const hoursInTf2 = await this.steamApiService.getTf2InGameHours(steamId);
+      if (hoursInTf2 < minimumTf2InGameHours) {
+        throw new Error('not enough tf2 hours');
+      }
+    } catch (e) {
+      if (e.message === 'cannot verify in-game hours for TF2' && minimumTf2InGameHours <= 0) {
+        return;
+      } else {
+        throw e;
+      }
+    }
+  }
+
 }