Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(games): add the /games/?playerId=<playerId> endpoint #470

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

garrappachc
Copy link
Member

This deprecates the old /players/<playerId>/games API.

@garrappachc garrappachc added enhancement New feature or request tech debt Paying technical debt labels Jun 25, 2020
@garrappachc garrappachc self-assigned this Jun 25, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #470 into master will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   88.42%   88.93%   +0.50%     
==========================================
  Files          80       81       +1     
  Lines        1901     1907       +6     
  Branches      214      213       -1     
==========================================
+ Hits         1681     1696      +15     
+ Misses        215      207       -8     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
src/players/controllers/players.controller.ts 76.19% <ø> (ø)
src/games/controllers/games.controller.ts 100.00% <100.00%> (+21.42%) ⬆️
src/shared/pipes/is-one-of.pipe.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059ab69...d82e7a7. Read the comment docs.

@garrappachc garrappachc merged commit 924b424 into tf2pickup-org:master Jul 2, 2020
@garrappachc garrappachc deleted the flatten-the-api branch July 2, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech debt Paying technical debt
Development

Successfully merging this pull request may close these issues.

1 participant