Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get rid of avatarUrl #813

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

garrappachc
Copy link
Member

BREAKING CHANGE: removes the avatarUrl propery from the Player model.

@garrappachc garrappachc added fix A fix to an issue tech debt Paying technical debt labels Jan 27, 2021
@garrappachc garrappachc self-assigned this Jan 27, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #813 (58d8202) into master (2bdcb1e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   91.28%   91.28%   -0.01%     
==========================================
  Files          93       93              
  Lines        2250     2249       -1     
  Branches      248      248              
==========================================
- Hits         2054     2053       -1     
  Misses        195      195              
  Partials        1        1              
Impacted Files Coverage Δ
src/players/models/player.ts 100.00% <ø> (ø)
src/players/services/players.service.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bdcb1e...148bed7. Read the comment docs.

@garrappachc garrappachc merged commit 927cbc3 into tf2pickup-org:master Feb 4, 2021
@garrappachc garrappachc deleted the remove-avatar-url branch February 4, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix to an issue tech debt Paying technical debt
Development

Successfully merging this pull request may close these issues.

1 participant