Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds AlaSQL support #1063

Closed
wants to merge 1 commit into from
Closed

adds AlaSQL support #1063

wants to merge 1 commit into from

Conversation

randomnerd
Copy link

@elhigu
Copy link
Member

elhigu commented Nov 21, 2015

I would like to see lots of tests for this. How does ala sql syntax compare to mysql / postgres / sqlite?

@rhys-vdw
Copy link
Member

rhys-vdw commented Dec 3, 2015

Hey, I'm for adding more dialects, but I can't really work out anything about AlaSQL's syntax from their website. The interactive console thingy doesn't seem to do anything when I press the 'run query' button.

The documentation suggests that the update statement doesn't support returning, but the client inherits from Postgres. Not sure if this PR addresses this, but obviously the entire thing needs tests.

@randomnerd are you planning to put in the necessary work to get this thing merged? That would mean comprehensive tests and any necessary documentation updates.

@elhigu
Copy link
Member

elhigu commented Mar 15, 2016

Moved this to issues and added link here if someone likes to finish this.

@elhigu elhigu closed this Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants