Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occasionally deployments do not get cleaned due to lock leaks #1779

Closed
Cyberboss opened this issue Jan 25, 2024 · 3 comments · Fixed by #1793 or #1820
Closed

Occasionally deployments do not get cleaned due to lock leaks #1779

Cyberboss opened this issue Jan 25, 2024 · 3 comments · Fixed by #1793 or #1820
Assignees
@Cyberboss
Labels
Area: Engine With regard to managing engine installations Area: Watchdog With regard to managing DreamDaemon servers Bug Something's fucky Priority: High Fix as soon as possible Work In Progress Issue being actively worked on
Milestone
v6.6.1

Comments

@Cyberboss
Copy link
Member

Cyberboss commented Jan 25, 2024 •
edited
Loading

Happens on both Windows and Linux. Workaround is restarting TGS
@Cyberboss Cyberboss added Bug Something's fucky Area: Engine With regard to managing engine installations Area: Watchdog With regard to managing DreamDaemon servers labels Jan 25, 2024
@Cyberboss Cyberboss self-assigned this Feb 2, 2024
@Cyberboss Cyberboss added the Work In Progress Issue being actively worked on label Feb 2, 2024
@Cyberboss Cyberboss modified the milestones: v6.1.6, v6.2.1 Feb 2, 2024
@Cyberboss Cyberboss modified the milestones: v6.2.1, v6.3.1 Feb 23, 2024
@Cyberboss Cyberboss pinned this issue Mar 1, 2024
@Cyberboss
Copy link
Member Author

Rules out initial dmb shenanigans as that's windows only.

@Cyberboss
Copy link
Member Author

This is most likely related to old compile jobs not cleaning up while the server is running as well.

@Cyberboss Cyberboss mentioned this issue Mar 2, 2024
Merged
@Cyberboss Cyberboss linked a pull request Mar 2, 2024 that will close this issue
v6.3.2: Fix a deployment directory leak #1793
Merged
@Cyberboss Cyberboss modified the milestones: v6.3.1, v6.3.2 Mar 24, 2024
@Cyberboss
Copy link
Member Author

Seen in 6.5.0

@Cyberboss Cyberboss reopened this May 12, 2024
@Cyberboss Cyberboss modified the milestones: v6.3.2, v6.5.1 May 12, 2024
@Cyberboss Cyberboss mentioned this issue Jun 16, 2024
Merged
@Cyberboss Cyberboss added the Priority: High Fix as soon as possible label Jun 16, 2024
@Cyberboss Cyberboss changed the title There's a bug where engine installations can't delete due to having an active reference somewhere Occasionally engine installations can't delete due to having an active reference somewhere Jul 6, 2024
@Cyberboss Cyberboss changed the title Occasionally engine installations can't delete due to having an active reference somewhere Occasionally deployments do not getting cleaned up due to leaking their locks Jul 6, 2024
@Cyberboss Cyberboss changed the title Occasionally deployments do not getting cleaned up due to leaking their locks Occasionally deployments do not get cleaned due to lock leaks Jul 6, 2024
@Cyberboss Cyberboss modified the milestones: v6.5.1, v6.6.1 Jul 6, 2024
@Cyberboss Cyberboss linked a pull request Jul 12, 2024 that will close this issue
v6.6.1: Deployment Lock State Auditing #1820
Merged
@Cyberboss Cyberboss unpinned this issue Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyberboss Cyberboss

Labels
Area: Engine With regard to managing engine installations Area: Watchdog With regard to managing DreamDaemon servers Bug Something's fucky Priority: High Fix as soon as possible Work In Progress Issue being actively worked on
Projects
None yet
Milestone
v6.6.1
1 participant
@Cyberboss