Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query frontend,store: redis config sends "default" instead of username #7103

Closed
AyalaEl opened this issue Jan 29, 2024 · 3 comments · Fixed by #7224
Closed

Query frontend,store: redis config sends "default" instead of username #7103

AyalaEl opened this issue Jan 29, 2024 · 3 comments · Fixed by #7224

Comments

@AyalaEl
Copy link

AyalaEl commented Jan 29, 2024

thanos version: 0.34.0, 0.33.0, 0.32.5
Redis version: 6.0.16

What happened:
Thanos is sending "default" instead of configured username to redis cache

What you expected to happen:
Thanos sends the username I configured in the config yaml.

How to reproduce it:
Configure a redis 6 cluster with username and password.
Configure the thanos frontend with cache config file:
Type: "REDIS"
config:
username: "username"
password: "password"
addr: "address:port"

Thanos 0.34.0 logs:
caller=main.go:135 level:error err="creating redis client: WRONGPASS invalid username-password pair"

The reddis logs show login attempts with username "default" and password "password"
I'm using images from dockerhub (thanosio/thanos)

@sergo3030
Copy link

I have the same issue! Did you find the fix?

@AyalaEl
Copy link
Author

AyalaEl commented Jan 31, 2024

I didn't :(

I did find this code:
https://github.com/thanos-io/thanos/blob/main/internal/cortex/chunk/cache/redis_client.go
I'm not sure if thats the correct file but It looks like they aren't even using the username.. (line 52)

@segevtsilis
Copy link

I also have this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants