This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit https://dashboard.github.orijtech.com?back=0&pr=555&remote=true&repo=crypto-facs%2Fethermint to see benchmark details. |
crypto-facs
commented
Sep 13, 2021
Codecov Report
@@ Coverage Diff @@
## main #555 +/- ##
=======================================
Coverage 53.77% 53.78%
=======================================
Files 64 64
Lines 5281 5282 +1
=======================================
+ Hits 2840 2841 +1
Misses 2307 2307
Partials 134 134
|
This pull request introduces 1 alert when merging df5d302 into 5a70dfb - view on LGTM.com new alerts:
|
fedekunze
reviewed
Sep 13, 2021
fedekunze
reviewed
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, minor comments only. Can you also update the docs and add a CHANGELOG entry?
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fedekunze
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
fedekunze
reviewed
Sep 15, 2021
fedekunze
added
automerge
Automatically merge PR once all prerequisites pass.
C:JSON-RPC
JSON-RPC client
labels
Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
debug_traceBlockByNumber
JSON RPC endpoint.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)