From 53aa5701940eb9db055749441046fd4b20ba15d7 Mon Sep 17 00:00:00 2001 From: xXParagoNXx Date: Tue, 23 Nov 2021 20:28:00 +0000 Subject: [PATCH] 56773 Review on code smell #11 --- .../code_smells_56971_reviewlog.txt | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/Project/Phase 1/Sprint 1/team_member_56971/code_smells_56971_reviewlog.txt b/Project/Phase 1/Sprint 1/team_member_56971/code_smells_56971_reviewlog.txt index ad394de14e8..950a3c75134 100644 --- a/Project/Phase 1/Sprint 1/team_member_56971/code_smells_56971_reviewlog.txt +++ b/Project/Phase 1/Sprint 1/team_member_56971/code_smells_56971_reviewlog.txt @@ -1,14 +1,18 @@ Team Member 58625 (Gabriela Costa) -Regarding the Dead Code code smell (code smell #10) + Regarding the Dead Code code smell (code smell #10) -"I don't think this can be classified as a case of dead code. This class is used, namely in /src/main/java/org/jabref/logic/autosaveandbackup/AutosaveManager.java, and /src/main/java/org/jabref/gui/dialogs/AutosaveUiManager.java. -In the first class, the AutosaveEvent object is used as a parameter to the listen() method, which needs it in order to identify the type of event triggered (in this case, an AutosaveEvent). -In the second class, the AutosaveEvent object allows us to place an event into the event bus to which the listen() method subscribes to. -In short, even though this class is empty, it is not dead code, since it serves a very specific purpose." -19:55 -23/11 + "I don't think this can be classified as a case of dead code. This class is used, namely in /src/main/java/org/jabref/logic/autosaveandbackup/AutosaveManager.java, and /src/main/java/org/jabref/gui/dialogs/AutosaveUiManager.java. + In the first class, the AutosaveEvent object is used as a parameter to the listen() method, which needs it in order to identify the type of event triggered (in this case, an AutosaveEvent). + In the second class, the AutosaveEvent object allows us to place an event into the event bus to which the listen() method subscribes to. + In short, even though this class is empty, it is not dead code, since it serves a very specific purpose." -19:55 -23/11 Team Member 56971 (João Vieira): -in response to Team Member 58625 (Gabriela Costa) regarding The Dead Code smell (code smell #10) + in response to Team Member 58625 (Gabriela Costa) regarding The Dead Code smell (code smell #10) -"I disagree, yes this class is used, I mentioned it my description but the reason I classified this as dead code is that the class is empty and adds no new functionality to the application. Its only purpose is to satisfy verifications, therefore believe this should not exist, at very least it could be something like a interface.A empty class is basically useless" -20:55 -23/11 + "I disagree, yes this class is used, I mentioned it my description but the reason I classified this as dead code is that the class is empty and adds no new functionality to the application. Its only purpose is to satisfy verifications, therefore believe this should not exist, at very least it could be something like a interface.A empty class is basically useless" -20:55 -23/11 + +Gonçalo Virgínia (56773): + + Code smell #11 (Duplicated Code): "Sounds good, simple fix."