Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed model unbind when model is also part of a collection #182

Closed
wants to merge 1 commit into from

Conversation

kinergy
Copy link
Contributor

@kinergy kinergy commented Nov 6, 2013

When calling unbind(this), I fixed a bug due to a missing 'else' where even if the view had a model, if the model was also part of a collection, all other collection models would be unbound. I don't think this is the correct behavior since different views that are concurrently showing may decide to change which model they are displaying. Without this fix, if one view did an unbind(), retrieved a new model, and then called bind(), then any other views would be unbound as well!

Please review,
Kimon

@kinergy
Copy link
Contributor Author

kinergy commented Dec 31, 2013

Hi there - happy new years!

Wanted to check in with you in case you have a chance to review this pull request. I just got bit by incorporating the unpatched 0.9.0 into my project and debugging the same issue that I created this pull request for :)

Best,
Kimon

@thedersen
Copy link
Owner

Thanks. Merged in 0.9.1

@thedersen thedersen closed this Jan 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants