Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On error process exits with exit code 0 #37

Closed
samoylovfp opened this issue Sep 13, 2020 · 2 comments
Closed

On error process exits with exit code 0 #37

samoylovfp opened this issue Sep 13, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@samoylovfp
Copy link
Contributor

samoylovfp commented Sep 13, 2020

Example:

mkdir empty_dir
cd empty_dir
trunk build
echo $?

prints 0
Expected any non-zero value.

trunk build obviously fails in an empty directory but the exit code is still 0.

Exit code is helpful to short-circuit a build pipeline if the "trunk build" step fails but without non-zero return code it is non-trivial to do.

P.S. Thanks for the awesome tool!

@thedodd
Copy link
Member

thedodd commented Sep 14, 2020

@samoylovfp thanks for the report! I'll knock this out in the 0.4.0 release, which will be going out shortly.

@thedodd thedodd added the bug Something isn't working label Sep 14, 2020
@thedodd thedodd self-assigned this Sep 14, 2020
@thedodd
Copy link
Member

thedodd commented Sep 14, 2020

Cheers! Done.

@thedodd thedodd added this to the 0.4.0 | TBD milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants