Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider trimming button locator text #11

Closed
cowboyd opened this issue Mar 23, 2021 · 1 comment
Closed

Consider trimming button locator text #11

cowboyd opened this issue Mar 23, 2021 · 1 comment

Comments

@cowboyd
Copy link
Member

cowboyd commented Mar 23, 2021

Just ran into this issue when trying out tests on Safari:

  ↪ visiting "/"
    ⨯ Sign in to FOLIO
      │ ERROR did not find button "Log in", did you mean one of:
      │
      │ ┃ button               ┃ visible: true ┃
      │ ┣━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━┫
      │ ┃ ⨯ "Log in\n"         ┃ ✓ true        ┃
      │ ┃ ⨯ "Forgot password?" ┃ ✓ true        ┃
      │ ┃ ⨯ "Forgot username?" ┃ ✓ true        ┃

As you can see, the only reason that the locators didn't match was because of the trailing "\n" which apparently the Safari DOM preserves for innerText and gecko and chrome do not.

@jnicklas jnicklas transferred this issue from thefrontside/bigtest Aug 27, 2021
@jnicklas
Copy link
Collaborator

Duplicate of #25

@jnicklas jnicklas marked this as a duplicate of #25 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants