Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default grid intensities not returned when only setting some segments in perVisitTrace #236

Closed
APJohns opened this issue Nov 7, 2024 · 2 comments

Comments

@APJohns
Copy link
Contributor

APJohns commented Nov 7, 2024

Describe the bug
When only providing one segment to gridIntensity in perVisitTrace, the returned variables.gridIntensity only shows what was provided and no longer shows the default global intensity for the other segments.

To Reproduce
Steps to reproduce the behavior:

  1. Call perVisitTrace using SWD model while only providing one or two segment grid intensities
  2. Notice returned variables.gridIntensities only contains the ones you set

Expected behavior
Returned variables.gridIntensity should show all intensities (including defaults).

Environment (please complete the following information):

  • NodeJS
@fershad
Copy link
Contributor

fershad commented Nov 12, 2024

@APJohns thanks for this. I've seen your PR too. I'll have a look at these on Friday this week when I've got a bit more bandwidth.

@fershad
Copy link
Contributor

fershad commented Nov 30, 2024

Thanks for this issue, and for the associated PR @APJohns

@fershad fershad closed this as completed Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants