Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

[glowing-bear-ssl-proxy] replaced internal docker ip addresses with dns names #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[glowing-bear-ssl-proxy] replaced internal docker ip addresses with dns names #45

wants to merge 1 commit into from

Conversation

tgymnich
Copy link
Contributor

Fixes #44

@tgymnich
Copy link
Contributor Author

tgymnich commented Dec 22, 2019 •
edited
Loading

Should we also remove the proxy part of the thehyve/glowing-bear image and only serve glowing-bear? The removed parts could be incorporated into glowing-bear-ssl-proxy.

We should also consider removing any unused for forwards after that.

@tgymnich tgymnich force-pushed the network_improvements branch 4 times, most recently from de4f57e to fe40436 Compare December 22, 2019 01:41
@tgymnich tgymnich force-pushed the network_improvements branch from fe40436 to 9e88ab1 Compare December 22, 2019 01:43
@tgymnich
Copy link
Contributor Author

tgymnich commented Dec 22, 2019 •
edited
Loading

importing external networks wasn't even necessary since we are overlaying the base image (docker-compose.yml) with the glowingbear-ssl-proxy.yml image meaning we can use all the previously defined networks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

glowing-bear-ssl-proxy should not rely on docker IP addresses
1 participant
@tgymnich