Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] support multiple remote connection of plugins #4509

Closed
ensorrow opened this issue Mar 8, 2019 · 9 comments · Fixed by #4521
Closed

[plugin] support multiple remote connection of plugins #4509

ensorrow opened this issue Mar 8, 2019 · 9 comments · Fixed by #4521
Assignees
Labels
bug bugs found in the application plug-in system issues related to the plug-in system

Comments

@ensorrow
Copy link
Contributor

ensorrow commented Mar 8, 2019

Is there any plan to fix this problem recently?

image

Plugins will be quite useless without this feature...

@akosyakov akosyakov added bug bugs found in the application plug-in system issues related to the plug-in system labels Mar 8, 2019
@akosyakov
Copy link
Member

@ensorrow Could you have a look?

@akosyakov
Copy link
Member

So does it mean that plugins only work for last page? @benoitf

@ensorrow
Copy link
Contributor Author

ensorrow commented Mar 8, 2019

So does it mean that plugins only work for last page? @benoitf

Yes, that's the problem. Only the last client can receive the message from server.

@akosyakov
Copy link
Member

Yes, just verified that it is broken.

@akosyakov akosyakov self-assigned this Mar 8, 2019
@akosyakov
Copy link
Member

akosyakov commented Mar 8, 2019

Right now the backend always run one plugin host process. It won't work for multiple clients since each client should have own context (opened dirty editors and so on). It's quite mind boggling to refactor to give each client its own plugin host process (especially on Friday afternoon), will see what can be done next week :)

@benoitf
Copy link
Contributor

benoitf commented Mar 8, 2019

akosyakov : So does it mean that plugins only work for last page? @benoitf

yes, I think there is an open issue but I'm not finding it :-/

@ensorrow
Copy link
Contributor Author

Hope you can close the issue this week😉.That’s the only problem we are facing now on developing a Theia based IDE.Theia is awesome.

akosyakov added a commit that referenced this issue Mar 11, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 11, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 11, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 11, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@ensorrow
Copy link
Contributor Author

Awesome!!!

@svenefftinge
Copy link
Contributor

Reopening as it is not merged, yet.

@svenefftinge svenefftinge reopened this Mar 12, 2019
akosyakov added a commit that referenced this issue Mar 13, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 13, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Mar 14, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants