Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the type of click event during node selection in tree views on plugin side #4805

Closed
vzhukovs opened this issue Apr 4, 2019 · 0 comments
Assignees
Labels
bug bugs found in the application plug-in system issues related to the plug-in system tree issues related to the tree (ex: tree widget)

Comments

@vzhukovs
Copy link
Contributor

vzhukovs commented Apr 4, 2019

Description

There is a problem, in concrete case it reproduces with Kubernetes Plugin.
When user opens Kubernetes Explorer and goes into specific nodes, for example to see configuration maps and select it with right click to call the context menu, the plugin side doesn't respect type of mouse click event and in any case call procedure to open selected node. This can be shown in rpc calls from plugin side:

"{"kind":"data","id":15,"content":"{\"jsonrpc\":\"2.0\",\"id\":18,\"method\":\"postMessage\",\"params\":\"[\\\"{\\\\\\\"hostID\\\\\\\":\\\\\\\"main\\\\\\\",\\\\\\\"type\\\\\\\":2,\\\\\\\"id\\\\\\\":\\\\\\\"32\\\\\\\"}\\\",\\\"{\\\\\\\"hostID\\\\\\\":\\\\\\\"main\\\\\\\",\\\\\\\"type\\\\\\\":1,\\\\\\\"id\\\\\\\":\\\\\\\"85\\\\\\\",\\\\\\\"proxyId\\\\\\\":\\\\\\\"DocumentsMain\\\\\\\",\\\\\\\"method\\\\\\\":\\\\\\\"$tryOpenDocument\\\\\\\",\\\\\\\"args\\\\\\\":[{\\\\\\\"$type\\\\\\\":1,\\\\\\\"data\\\\\\\":\\\\\\\"k8smsx://loadkubernetescore/configmap-game-config.yaml?value%3Dconfigmap%2Fgame-config%26_%3D1554365947271\\\\\\\"},null]}\\\"]\"}"}"

Plugin side should respect the right click and show only the context menu, instead of force setting up global selection and fire procedures to open selected node.

@vzhukovs vzhukovs added bug bugs found in the application tree issues related to the tree (ex: tree widget) plug-in system issues related to the plug-in system labels Apr 4, 2019
@vzhukovs vzhukovs self-assigned this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

No branches or pull requests

1 participant