Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file icon centered #5725

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

hacke2
Copy link
Contributor

@hacke2 hacke2 commented Jul 16, 2019

Signed-off-by: hacke2 hacke2cn@gmail.com

The file icons don't seem to be in the right place when open quickopen widget.

before:
image

after:
image

@vince-fugnitto
Copy link
Member

@hacke2 thank you for contributing!

In order to accept your contribution please make sure to sign-off your commit and sign the eclipse eca. It is the reason for the failed checks.

@hacke2 hacke2 force-pushed the fix/quickopen-file-icon branch from a4ee45d to f45e55f Compare July 16, 2019 14:00
@hacke2
Copy link
Contributor Author

hacke2 commented Jul 16, 2019

@vince-fugnitto Done.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better now thank you! 👍
I tested the quick-file-open and the icons are much better aligned as compared to master.

@vince-fugnitto
Copy link
Member

@hacke2 I'll wait for the CI to pass and I'll merge the PR for you.

@vince-fugnitto
Copy link
Member

@hacke2 you can also fix the following in this PR if you'd like #5726

@hacke2
Copy link
Contributor Author

hacke2 commented Jul 17, 2019

image

Signed-off-by: hacke2 <hacke2cn@gmail.com>
@hacke2 hacke2 force-pushed the fix/quickopen-file-icon branch from 8ec60cf to e312a62 Compare July 17, 2019 02:42
@vince-fugnitto
Copy link
Member

@hacke2 thank you for your contribution! 👍

@vince-fugnitto vince-fugnitto merged commit 613069f into eclipse-theia:master Jul 17, 2019
@hacke2 hacke2 deleted the fix/quickopen-file-icon branch July 22, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants