Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] support when closure for views #5855

Merged
merged 1 commit into from
Aug 7, 2019
Merged

[vscode] support when closure for views #5855

merged 1 commit into from
Aug 7, 2019

Conversation

akosyakov
Copy link
Member

What it does

fix #5853 - support when closure for views:

  • a view visibility should be auto toggled based on when view closure
  • if a user explicitly hides a view, then auto toggling should be disabled
  • and it should be enabled again when a user explicitly unhides the view

How to test

See for how install VS Code extension :https://github.com/theia-ide/theia/wiki/Testing-VS-Code-Extensions

Review checklist

Reminder for reviewers

@akosyakov akosyakov added shell issues related to the core shell vscode issues related to VSCode compatibility labels Aug 5, 2019
@akosyakov
Copy link
Member Author

@kpge Could you test please whether it fixes #5853 with npm extension? Thank you!

@kpge
Copy link
Contributor

kpge commented Aug 6, 2019

@kpge Could you test please whether it fixes #5853 with npm extension? Thank you!

@akosyakov LGTM

  • The npm scripts is disappeared by default(config.npm.enableScriptExplorer = false)
  • The npm scripts is displayed when config.npm.enableScriptExplorer = true

but I think npm config should be always displayed in Preferences dialog , no matter the project is a npm project.
in a java project:
image
in a npm project:
image

@akosyakov
Copy link
Member Author

but I think npm config should be always displayed in Preferences dialog , no matter the project is a npm project.

@kpge Thank you for testing the PR! Could you file a separate issue for it? We need to check how it behaves in VS Code before fixing as well. If you can do it, it would help.

- a view visibility should be auto toggled based on `when` view closure
- if a user explicitly hides a view, then auto toggling should be disabled
- and it should be enabled again when a user explicitly unhides the view

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @akosyakov! I quickly checked that it properly registers the JSON type of the current editor in the example plugin. Code looks good to me as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell issues related to the core shell vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pluginExt] npm scripts showed when config.npm.enableScriptExplorer is false after npm extension installed
3 participants