Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force refresh button in navigator #5940

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

kpge
Copy link
Contributor

@kpge kpge commented Aug 14, 2019

What it does

add a force-refresh button on the toolbar in nagigator as pointed in #5885
image

How to test

It's hard to test, because file watcher will called fileChanged function, and auto refresh the file tree.
There are two ways to test it:

  • First one is check the websocket request in devtools:
    when click force-refresh button, it will send getFileStat request to backend and receive a file node message.
    force refresh
  • Another way to test :
  1. change the value of fs.inotify.max_user_watches to default value(8192) to diable the file wathcer.
    echo fs.inotify.max_user_watches=8192| sudo tee -a /etc/sysctl.conf && sudo sysctl -p
  2. start theia app and open a large project (such as theia workspace) in browser.
  3. create a new file or folder and click refresh button.
    force refresh 2

Review checklist

Reminder for reviewers

@akosyakov akosyakov requested review from vince-fugnitto and vzhukovs and removed request for vince-fugnitto August 14, 2019 06:52
@akosyakov akosyakov added the navigator issues related to the navigator/explorer label Aug 14, 2019
@kpge kpge force-pushed the kpge/force-refresh branch from c9f4f49 to 7b85068 Compare August 14, 2019 07:29
Copy link
Contributor

@vzhukovs vzhukovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. @kpge thanks for adding this item!

Signed-off-by: kpge <gekangping@126.com>
@kpge kpge force-pushed the kpge/force-refresh branch from 7b85068 to 4b87a57 Compare August 14, 2019 12:34
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @kpge 👍

@vince-fugnitto vince-fugnitto merged commit 17bfcb2 into eclipse-theia:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants