Display leading and trailing whitespaces in search-in-workspace results #5989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
bug
|
Tested in example browser, and I can confirm
after entered "tabs" into the editor and performed a search, theia is like dead. but I don't think it is related to this pull request. |
elaihau
approved these changes
Aug 20, 2019
|
I am not able to reproduce the problem I described earlier (i.e., entered "tabs" into the editor and performed a search, and then theia is dead). Ignore it please. |
AlexTugarev
reviewed
Aug 20, 2019
Fixes #5987 - fixed an issue where leading and trailing whitespaces were not being displayed from the `search-in-workspace` result tree leading to confusion and overall an annoying behavior. - added an additional test to `ripgrep-search-in-workspace-server.slow-spec.ts` which tests the result of a search including a trailing whitespace. - added an additional test to `ripgrep-search-in-workspace-server.slow-spec.ts` which tests the result of a search including a leading whitespace. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/GH-5987
branch
from
0997e54 to
acb4fff
Compare
AlexTugarev
reviewed
Aug 20, 2019
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Show resolved
Hide resolved
AlexTugarev
approved these changes
Aug 20, 2019
|
Thank you @elaihau @AlexTugarev for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #5987
from the
search-in-workspaceresult tree leading to confusion and overall anannoying behavior.
ripgrep-search-in-workspace-server.slow-spec.tswhichtests the result of a search including a trailing whitespace.
ripgrep-search-in-workspace-server.slow-spec.tswhichtests the result of a search including a leading whitespace.
How to test
theia/packages/bunyan)replacefunctionality enabled (click the toggle replace icon (small triangle) and enter a replace term) - the leading and trailing whitespaces should also be displayed with the strikethrough)Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com