Fix menu bar color. #6014
Merged
Fix menu bar color. #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the font color is set generally for widgets the menu bar did not get its individual color. The css rule got refined to be not overwritten by the p-widget rule. Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
| @@ -30,7 +30,7 @@ | |||
| |----------------------------------------------------------------------------*/ | |||
|
|
|||
|
|
|||
| .p-MenuBar { | |||
| .p-Widget.p-MenuBar { | |||
There was a problem hiding this comment.
So p-MenuBar is not used anymore?
What about this reference https://github.com/theia-ide/theia/blob/89c3e75f4a75f5850b7797ad6af3ca8ac3700149/packages/core/src/browser/style/menus.css#L60
There was a problem hiding this comment.
So p-MenuBar is not used anymore?
Only in p-Widget container. Are there other containers where it maybe could be used in?
What about this reference
Since this rule is not affected by the p-Widget rule I left it out.
svenefftinge
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Since the font color is now set generally for widgets the menu bar did not get its individual color anymore.
The css rule got refined to be not overwritten by the p-widget rule.
How to test
Use a different font color for the menu. For that in theme variable css which you are currently using (e.g.
variables-dark.useable.css) change the variable--theia-ui-bar-font-color1(used by the menu bar). Before that change it had no effect.After the change the menu bar has an individual font color again.
Review checklist
Reminder for reviewers