Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements #51

Merged
merged 7 commits into from
Aug 9, 2018
Merged

various improvements #51

merged 7 commits into from
Aug 9, 2018

Conversation

akosyakov
Copy link
Contributor

@akosyakov akosyakov commented Aug 6, 2018

This PR contains the following improvements:

  • diagnostics interruption to improve response time for other requests, as completion and signature help
  • applied refactorings support
  • suggest diagnostics support
  • diagnostics buffering
  • tolerating non-file URIs
  • organize imports

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov changed the title WIP interrupt diagnostics to response quicker for other features WIP interrupt diagnostics to response quicker on other requests Aug 6, 2018
@akosyakov
Copy link
Contributor Author

akosyakov commented Aug 6, 2018

  • improve handling of cancel errors:
example: ts Server: (node:18925) UnhandledPromiseRejectionWarning: Error: Cancelled Request 122
example:     at token.onCancellationRequested (/workspace/typescript-language-server/server/lib/tsp-client.js:72:41)
example:     at CallbackList.invoke (/workspace/typescript-language-server/node_modules/vscode-jsonrpc/lib/events.js:71:39)
example:     at Emitter.fire (/workspace/typescript-language-server/node_modules/vscode-jsonrpc/lib/events.js:135:36)
example:     at MutableToken.cancel (/workspace/typescript-language-server/node_modules/vscode-jsonrpc/lib/cancellation.js:39:31)
example:     at CancellationTokenSource.cancel (/workspace/typescript-language-server/node_modules/vscode-jsonrpc/lib/cancellation.js:89:25)
example:     at LspServer.cancelDiagnostics (/workspace/typescript-language-server/server/lib/lsp-server.js:149:41)
example:     at LspServer.interuptDiagnostics (/workspace/typescript-language-server/server/lib/lsp-server.js:117:14)
example:     at LspServer.<anonymous> (/workspace/typescript-language-server/server/lib/lsp-server.js:314:39)
example:     at Generator.next (<anonymous>)
example:     at /workspace/typescript-language-server/server/lib/lsp-server.js:13:71
example: ts Server: (node:18925) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
example: (node:18925) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
  • check an effect with Theia repo

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov changed the title WIP interrupt diagnostics to response quicker on other requests WIP various improvements Aug 7, 2018
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the ak/interrupt branch 2 times, most recently from f632250 to a6cf729 Compare August 8, 2018 09:33
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Contributor Author

@svenefftinge please review, I will do Rename File in a separate command, it is involving on Theia side

@akosyakov akosyakov merged commit 101dae4 into master Aug 9, 2018
@akosyakov akosyakov deleted the ak/interrupt branch August 9, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants