Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sidebar->dimmer to true will make element on page unclickable #820

Closed
5 of 11 tasks
LEAFERx opened this issue Apr 7, 2019 · 4 comments · Fixed by #964
Closed
5 of 11 tasks

Set sidebar->dimmer to true will make element on page unclickable #820

LEAFERx opened this issue Apr 7, 2019 · 4 comments · Fixed by #964

Comments

@LEAFERx
Copy link
Contributor

LEAFERx commented Apr 7, 2019

I agree and want to create new issue


Expected behavior

When sidebar is open, I can still click links/buttons and select text on page normally.

Actual behavior

When sidebar is open, I can not click links/buttons directly. I have click twice, one for close sidebar one for clicking links/buttons. Also, I can not select text when sidebar is open.

Steps to reproduce the behavior

  1. in theme _config.yml, set sidebar->dimmer to true
  2. visit any blog page
  3. open sidebar
  • Link to demo site with this bug: any post at https://leaferx.online
  • Link(s) to source code or any usefull link(s): N/A

Node.js and NPM Information

v10.4.1
6.1.0

Package dependencies Information

{
  "name": "hexo-site",
  "version": "0.0.0",
  "private": true,
  "hexo": {
    "version": "3.8.0"
  },
  "dependencies": {
    "babel-core": "^6.26.3",
    "babel-preset-es2015": "^6.24.1",
    "babelify": "^8.0.0",
    "browserify": "^16.2.3",
    "gulp-babel": "^6.1.3",
    "gulp-htmlclean": "^2.7.20",
    "gulp-htmlmin": "^4.0.0",
    "gulp-minify-css": "^1.2.4",
    "gulp-uglify": "^3.0.0",
    "hexo": "^3.8.0",
    "hexo-autonofollow": "^1.0.1",
    "hexo-baidu-url-submit": "0.0.5",
    "hexo-deployer-git": "^0.3.1",
    "hexo-generator-archive": "^0.1.5",
    "hexo-generator-category": "^0.1.3",
    "hexo-generator-feed": "^1.2.2",
    "hexo-generator-index-pin-top": "^0.2.2",
    "hexo-generator-searchdb": "^1.0.8",
    "hexo-generator-sitemap": "^1.2.0",
    "hexo-generator-tag": "^0.2.0",
    "hexo-leancloud-counter": "^0.2.10",
    "hexo-leancloud-counter-security": "^1.3.1",
    "hexo-renderer-ejs": "^0.3.1",
    "hexo-renderer-markdown-it": "^3.4.1",
    "hexo-renderer-stylus": "^0.3.3",
    "hexo-server": "^0.3.3",
    "hexo-symbols-count-time": "^0.3.2",
    "markdown-it-footnote": "^3.0.1"
  },
}

Hexo Information

Hexo version

hexo: 3.8.0
hexo-cli: 1.1.0
os: Windows_NT 10.0.17134 win32 x64
http_parser: 2.8.0
node: 10.4.1
v8: 6.7.288.45-node.7
uv: 1.20.3
zlib: 1.2.11
ares: 1.14.0
modules: 64
nghttp2: 1.32.0
napi: 3
openssl: 1.1.0h
icu: 61.1
unicode: 10.0
cldr: 33.0
tz: 2018c

Hexo Configuration

not relevant

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

NexT Configuration:

sidebar:
  dimmer: true

Other Information

N/A

@LEAFERx LEAFERx added the Bug label Apr 7, 2019
@1v9
Copy link
Member

1v9 commented Apr 8, 2019

Also clicking the body of archive page won't close the sidebar.I think they aren't bugs but need improvement.

@LEAFERx
Copy link
Contributor Author

LEAFERx commented Apr 8, 2019

Solutions maybe:

  1. add event listener to body, when click on non-interactive element (eg. not links/buttions/text/not-binded-click-event) and outside of sidebar, close sidebar.

or

  1. add a option that dimmer-only-on-mobile, cause it seems not very useful on big screen device but on small screen device sidebar hide the post and there's shadow outside the sidebar.

@stevenjoezhang
Copy link
Contributor

#606
#607

@stevenjoezhang stevenjoezhang changed the title set sidebar->dimmer to true will make element on page unclickable Set sidebar->dimmer to true will make element on page unclickable May 20, 2019
@stevenjoezhang
Copy link
Contributor

Fixed in #964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants