Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentence scanning to include image alt text (e.g. emoji) #467

Open
toasted-nutbread opened this issue Dec 27, 2023 · 2 comments
Open

Sentence scanning to include image alt text (e.g. emoji) #467

toasted-nutbread opened this issue Dec 27, 2023 · 2 comments
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@toasted-nutbread
Copy link

Emoji are sometimes used in writing or communication, but the sentence scanning functionality ignores them, so this context will be truncated when added to Anki cards. Could potentially be nice to support this if it doesn't add significant complexity. On the other hand, it's not as trivial as it may seem, since most emoji are composed of UTF16 surrogate pairs. Anyway, just an issue to put on the radar.

@toasted-nutbread toasted-nutbread added the kind/enhancement The issue or PR is a new feature or request label Dec 27, 2023
@Casheeew
Copy link
Member

seems to be working fine for me
image
image

@toasted-nutbread
Copy link
Author

So I think it does work when normal emoji are used, which I didn't actually test because I forgot that websites will often replace them with their own custom emoji, take discord for example:

<img aria-label="💀" src="https://discord.com/assets/71e7a2f93eca777dc211.svg" alt="💀" draggable="false" class="emoji" data-type="emoji" data-name=":skull:">

#359 is also related

So basically including image alt text in scans would be useful.

@toasted-nutbread toasted-nutbread changed the title Sentence scanning to include emoji Sentence scanning to include image alt text (e.g. emoji) Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

No branches or pull requests

2 participants