-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant escaping is still an issue #856
Comments
This should have been fixed since 24.4.7.0 Which handlebar are you using for that field? It might also be helpful if you can provide your full handlebars code under Edit: If you were using any of the cloze handlebars or the sentence handlebar you can ignore this. I've found an issue there and put in a fix. BUT if you were using a different handlebar I do still need this info. |
Looked into this a bit and it seems to be the same issues as #686 just with a different handlebar. Theres a few handlebars having this issue right now. |
You dont have to wait for the update to fix these, just replace any of the following handlebars youre using with these new ones under
|
Thanks. If I implement #856 (comment), will it conflict with the changes introduced by #857? If so, I'd rather wait for the true fix. |
No, handlebars updates work by find and replace. If it can't find the broken handlebar to replace (you've already replaced it yourself) it can't replace a second time so there's nothing for it to break. |
Will the proposed solution work if I'm using I'm trying out the solution, but I don't see |
Added that to the pr, heres the handlebar:
|
What version of the extension was #722 supposed to be deployed on?
I have Yomitan 24.4.16.0 running on Brave 1.65.114 Chromium: 124.0.6367.60 (Official Build) (x86_64) and it's still an issue.
The text was updated successfully, but these errors were encountered: