fix: welcome page no longer loads multiple times #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djahandarie
requested changes
Mar 30, 2023
djahandarie
force-pushed
the
fix_welcome_page
branch
4 times, most recently
from
438fdfe
to
f486de4
Compare
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
|
@Aquafina-water-bottle Any chance you could rebase this on master cleanly without having the merge commit? |
Aquafina-water-bottle
force-pushed
the
fix_welcome_page
branch
from
2b14673
to
de86f4d
Compare
djahandarie
force-pushed
the
fix_welcome_page
branch
from
de86f4d
to
033d38d
Compare
djahandarie
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112. However, this is pretty much a band-aid fix for one small problem. We might want to look further into #114 to see if there is a better way of fixing the non-persistent extension issue overall.