Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move search parser option under settings modal #1281

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Move search parser option under settings modal #1281

merged 2 commits into from
Jul 28, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Jul 28, 2024 •
edited
Loading

Fixes #1258

How it looks now (parser setting is hidden for users who have not set up mecab parsing):
image

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design labels Jul 28, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner July 28, 2024 18:59
@Kuuuube Kuuuube added this pull request to the merge queue Jul 28, 2024
Merged via the queue into yomidevs:master with commit 0288b24 Jul 28, 2024
10 of 11 checks passed
@Kuuuube Kuuuube deleted the fix-search-align branch July 28, 2024 19:05
@github-actions GitHub Actions
Copy link

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Casheeew Casheeew Casheeew approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken layout on Search Page
2 participants
@Kuuuube @Casheeew