-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox fixes #209
Firefox fixes #209
Conversation
@praschke Very nice! Thank you. This fixes a ton of small problems and gets rid of MV2 / fallback cruft. One question: what is |
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
|
Got it, makes sense, thank you for elaborating! In that case LGTM! |
8310381
to
8e20a9e
Compare
Firefox added the scripting API in 102. This should fix the majority of warnings listed in yomidevs#96: - insertCSS - executeScript - getRegisteredContentScripts - contentScripts.register - registerContentScripts - unregisterContentScripts
the API accepts string literals, which is all this enum provides. This should fix two warnings in yomidevs#96.
`declarativeNetRequest.updateDynamicRules()` returns with an unexpected error in Firefox, but only after the browser has been restarted. On a fresh install of Yomitan it works, causing bug flakiness. `declarativeNetRequest` can be disabled in the manifest as a workaround.
8e20a9e
to
303c51b
Compare
this line serves no purpose. the commit it was introduced in has the message 'Document RequestBuilder' and is the only non-documentary line in the commit. related to yomidevs#204.
window.getSelection()
can return null on FF, throwing some noisy errorsdeclarativeNetRequest
on FF that breaks after the browser restarts.Fixes #173. Improves #96. The remaining lint warnings on FF pertain to
storage.session
and eval in Handlebars and WanaKana.