Permissions fixups #293
Merged
Permissions fixups #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamic rules were never cleared, as the promise is not iterable as expected.
session rules are less persistent than dynamic rules, and the intention of RequestBuilder is to only have rules active for the lifetime of specific requests.
firefox was previously unable to use declarativeNetRequest, as some browser state (ExtensionDNRStore) wasn't correctly initialized wrt yomitan's use of the DNR API. this bug manifested as an unexpected error on calls to updateDynamicRules(), specifically after the browser has been restarted. switching to the use of session rules instead of dynamic rules fixes this bug. i have tested audio info requests (custom JSON, JPod Alternate, Jisho) that exhibited the bug after browser restart on version 115 and 118, and the audio plays instead of the request failing. webRequest can now be entirely removed.
this is the only blocker to Firefox for Android.
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
|
i just realized having session restore enabled may exhibit the same bug with session rules, but i checked and the bug is not present. |
djahandarie
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchInternalwithfetchin the declarative path, removewebRequestfrom ChromeupdateDynamicRuleson Firefox, remove thewebRequestpath entirelynativeMessagingalways optional (this has been possible for a while), unblock Firefox for Androidfirefox-mobileand guard the MeCab andnativeMessagingsettingswhile enabling the
nativeMessagingpermission on Firefox for Android might break the installation, the permissions toggles don't seem to enable them anyway (permissions work a bit differently on Android).while the extension can be signed for Android, it can't actually be installed, as the only way to install extensions on Firefox for Android requires a release on AMO.