Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Non JP Scanning Option for Kanji Dictionaries #372

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fix Non JP Scanning Option for Kanji Dictionaries #372

merged 3 commits into from
Dec 18, 2023

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Dec 17, 2023

Resolves #369

@MarvNC MarvNC requested a review from a team as a code owner December 17, 2023 23:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2023 •
edited
Loading

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

toasted-nutbread
toasted-nutbread reviewed Dec 18, 2023
View reviewed changes
Copy link

@toasted-nutbread toasted-nutbread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/data/translator-test-inputs.json

optionsPresets.kanji needs to have removeNonJapaneseCharacters added

@djahandarie djahandarie added this pull request to the merge queue Dec 18, 2023
Merged via the queue into yomidevs:master with commit fef568b Dec 18, 2023
5 checks passed
@MarvNC MarvNC deleted the fix-kanji-nonjpscanning branch December 18, 2023 10:02
@toasted-nutbread toasted-nutbread mentioned this pull request Dec 19, 2023
Merged
@djahandarie djahandarie added the kind/bug The issue or PR is regarding a bug label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toasted-nutbread toasted-nutbread toasted-nutbread approved these changes

@djahandarie djahandarie djahandarie approved these changes

Assignees
No one assigned
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kanji Lookups Bypass the Search Text With Non-Japanese Characters Option
3 participants
@MarvNC @djahandarie @toasted-nutbread