Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 出来る/できる as inflections of する #419

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Add 出来る/できる as inflections of する #419

merged 3 commits into from
Dec 22, 2023

Conversation

Casheeew
Copy link
Member

This change rebases the yomichan PR FooSoft#2266 for yomitan.

  • できる and 出来る correctly matches 出来る as first entry
    image
  • 全うできる correctly matches to 全うする
    image
  • 口を糊できる correctly matches to 口を糊する

@Casheeew Casheeew requested a review from a team as a code owner December 21, 2023 23:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited
Loading

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

toasted-nutbread
toasted-nutbread approved these changes Dec 21, 2023
View reviewed changes
Copy link

@toasted-nutbread toasted-nutbread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a safe change, I can't think of any infinite sequences off the top of my head that could be generated from this.

@djahandarie djahandarie added this pull request to the merge queue Dec 22, 2023
Merged via the queue into yomidevs:master with commit c18141a Dec 22, 2023
5 checks passed
@Casheeew Casheeew deleted the dekiru_suru branch December 26, 2023 07:32
@djahandarie djahandarie added the kind/enhancement The issue or PR is a new feature or request label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toasted-nutbread toasted-nutbread toasted-nutbread approved these changes

@djahandarie djahandarie djahandarie approved these changes

Assignees
No one assigned
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Casheeew @djahandarie @toasted-nutbread @tomtung