Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry selection arrow padding in search #754

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Mar 1, 2024

Fixes #753

This appears to have been changed in #705 to align the search options and search textbox but did not take into account the selection arrow. I've fixed the padding on the arrow while keeping the search options and search textbox aligned.

@Kuuuube Kuuuube requested a review from a team as a code owner March 1, 2024 19:48
Copy link

codspeed-hq bot commented Mar 1, 2024

CodSpeed Performance Report

Merging #754 will not alter performance

Comparing Kuuuube:fix-search-padding (67a2070) with master (e47a0f4)

Summary

✅ 4 untouched benchmarks

Copy link

github-actions bot commented Mar 1, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@Casheeew Casheeew added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design labels Mar 2, 2024
@djahandarie djahandarie added this pull request to the merge queue Mar 3, 2024
Merged via the queue into yomidevs:master with commit f162884 Mar 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search page selection indicator now overlaps with entry headword
4 participants