add single dictionary handlebars #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
StefanVukovic99
added
kind/enhancement
StefanVukovic99
force-pushed
the
single-dictionary-handlebars
branch
from
94d1cdd
to
64dcc9e
Compare
|
Only problem I see with this is the handlebars dont work in the |
|
The tester should also support them now, nice catch. |
Kuuuube
approved these changes
May 4, 2024
jamesmaa
approved these changes
May 5, 2024
| @@ -19,7 +19,7 @@ | |||
| import {isObjectNotArray} from '../core/object-utilities.js'; | |||
|
|
|||
| /** @type {RegExp} @readonly */ | |||
| const markerPattern = /\{([\w-]+)\}/g; | |||
| const markerPattern = /\{([\p{Letter}\p{Number}_-]+)\}/gu; | |||
There was a problem hiding this comment.
This is just a QOL change with no functional change? I can't find the documentation for this 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automatically generated handlebars for each of the enabled dictionaries, for splitting mono- and bilingual dictionaries and similar uses. Closes #322