Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Old Irish #831

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Added Old Irish #831

merged 7 commits into from
Apr 16, 2024

Conversation

martholomew
Copy link

Let me know if anything needs more explaining or if the code looks bad.

Thanks!

martholomew and others added 5 commits April 16, 2024 19:43
* fix (#811)

* Add scanOnTouchTap and improve touch scanning defaults (#791)

* Add scanOnTouchTap

* Update version to 30

* Cleanup if statement

* log anki error when hiding button (#821)

* Fix noteInfos not getting assigned (#819)

* improve term sorting (#806)

* improve term sorting

* edge case

* fix: add missing handlebar entry (#823)

* fix: add missing handlebar entry

* fix: add new handlebar to tests

* Revert to using canAddNotes (#827)

Fix #818

* Remove unused canAdd (#824)

Co-authored-by: James Maa <jamesmaa@Jamess-MacBook-Pro.local>

* Fix duplicate check not working across note types (#830)

* Fix duplicate check not working across note types

* Add invalidNoteId

---------

Co-authored-by: James Maa <jmaa@berkeley.edu>

---------

Co-authored-by: StefanVukovic99 <stefanvukovic44@gmail.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Co-authored-by: m-edlund <me@fwegmann.com>
Co-authored-by: Eloy Robillard <eloy.robillard@gmail.com>
Co-authored-by: James Maa <jmaa@berkeley.edu>
Co-authored-by: James Maa <jamesmaa@Jamess-MacBook-Pro.local>
@martholomew martholomew requested a review from a team as a code owner April 16, 2024 18:53
Copy link

github-actions bot commented Apr 16, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Apr 16, 2024
@jamesmaa jamesmaa added this pull request to the merge queue Apr 16, 2024
Merged via the queue into yomidevs:master with commit a952e2f Apr 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants