Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blue variants of the add duplicate buttons #860

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Apr 23, 2024

Since we're using green for the add button and red for the add duplicate button it's probably a good idea to have these available in a different color for people who are colorblind. Due to the buttons having a different shape there shouldn't be issues differentiating them but I think it's worth having for potential increased visual clarity for users who may need it.

Unsure about adding a setting for this or how it would be implemented (might be better to make a global colorblind mode?) but by simply adding the svgs we can make it available through custom css and decide later what else to do about this, if anything.

.icon[data-icon="add-duplicate-term-kanji"] { background-image: url('/images/add-duplicate-term-kanji-blue.svg'); }
.icon[data-icon="add-duplicate-term-kana"] { background-image: url('/images/add-duplicate-term-kana-blue.svg'); }

This is how the blue buttons look:
add-duplicate-term-kanji
add-duplicate-term-kana

@Kuuuube Kuuuube requested a review from a team as a code owner April 23, 2024 23:02
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Apr 23, 2024
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@jamesmaa jamesmaa added this pull request to the merge queue Apr 26, 2024
Merged via the queue into yomidevs:master with commit 5508a4d Apr 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants