-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework settings #884
Rework settings #884
Conversation
View Playwright Report (note: open the "playwright-report" artifact) |
…advanced, add child element Frequency sorting mode to advanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think reordering the general section is ok, all the things that got moved to advanced also ok.
When moving things out of advanced, I would generally err on the side of keeping them there, so settings are streamlined for new users. Users following guides will necessarily customize a lot of stuff, so they will need Advanced. Specifically, i think there tends to be bias towards features that recently got attention, even though the default is ok for most new users (like the duplicate setting here; don't think the reading mode is changed often either?).
I think ideally we want users to not have to use advanced unless they really need to do something out of the ordinary. Some guides will for sure be doing this ofc. The only one I've pulled out of advanced that I can see being an issue is the anki dupe checking. That one could reasonably go back in for sure. Frequency sorting dicts almost everyone uses so we shouldn't have that in advanced. And the other 3 appearance options just seem like really basic stuff that should just be there. |
Co-authored-by: James Maa <jmaa@berkeley.edu> Signed-off-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Everything should be ready for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think after this PR we should really prioritize making it easy to install dictionaries without leaving yomitan. The welcome page looks good and polished enough to fool people into thinking yomitan will work out of the box when in reality that's not the case
Summary of changes:
Welcome Page:
Settings Page:
Open to feedback and additional changes.