Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent updating dict entry details for anki when anki is disabled #909

Merged
merged 3 commits into from
May 11, 2024
Merged

Prevent updating dict entry details for anki when anki is disabled #909

merged 3 commits into from
May 11, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented May 11, 2024

Fixes #813
Fixes #878

Turns out this issue was not fully fixed by #843

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/anki The issue or PR is related to Anki integration labels May 11, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner May 11, 2024 02:30
jamesmaa
jamesmaa reviewed May 11, 2024
View reviewed changes
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually don't know too much about how this file works. If no one reviews in 24 hours I'll merge it

ext/js/display/display-anki.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@jamesmaa jamesmaa added this pull request to the merge queue May 11, 2024
Merged via the queue into yomidevs:master with commit 2bcb0bc May 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/anki The issue or PR is related to Anki integration kind/bug The issue or PR is regarding a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome: Yomitan Icon displays error upon scanning any text Console error when disabling Anki integration
2 participants
@Kuuuube @jamesmaa