-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework dictionary import UX #937
Conversation
If you can click the big button to open the file picker maybe the bottom button is redundant? |
…ng steps (roughly 500 items)
My UI hot take: drag-and-drop is an advanced user feature and can actively work against most users' intuition of how to upload files. My SWAG is that 80% of users prefer Click to Upload over drag and drop. Here are some examples of drag and drop UI's in other popular platforms: My suggestion is to go with FB's approach as it makes the upload file button much bitter and supports drag and drop for other users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review the code details very carefully but this looks fine and looks well tested/polished and the breakage risk is low so
Adds drag and drop functionality and the option to import dictionaries from a url.