Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework dictionary import UX #937

Merged
merged 23 commits into from
May 21, 2024
Merged

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented May 14, 2024

Adds drag and drop functionality and the option to import dictionaries from a url.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels May 14, 2024
@Kuuuube Kuuuube changed the title Add option to import dictionaries from URL Rework dictionary import UX May 15, 2024
@Kuuuube
Copy link
Member Author

Kuuuube commented May 15, 2024

Fixed up the UI and added drag and drop functionality.

Upon clicking Import Dragging file
image image

@Kuuuube Kuuuube marked this pull request as ready for review May 15, 2024 17:19
@Kuuuube Kuuuube requested a review from a team as a code owner May 15, 2024 17:19
@Kuuuube
Copy link
Member Author

Kuuuube commented May 16, 2024

Current UI:

Upon clicking Import Dragging file
image image

I've also left in the Import from URLs option for now but it only appears if advanced settings are enabled and the textarea is much smaller.

@MarvNC
Copy link
Member

MarvNC commented May 16, 2024

If you can click the big button to open the file picker maybe the bottom button is redundant?

@jamesmaa
Copy link
Collaborator

My UI hot take: drag-and-drop is an advanced user feature and can actively work against most users' intuition of how to upload files.

My SWAG is that 80% of users prefer Click to Upload over drag and drop.

Here are some examples of drag and drop UI's in other popular platforms:
Google drive: No indication it is supported but if you drag and drop into gdrive it works
image
FB: Indicates both options but prioritizes clicking the button first and de-emphasizes drag and drop
Screenshot 2024-05-15 at 9 08 17 PM
Github:
image
Youtube: Prioritizes drag and drop but adds a clear button to let users know a file browser is available as well
image

My suggestion is to go with FB's approach as it makes the upload file button much bitter and supports drag and drop for other users

@Kuuuube
Copy link
Member Author

Kuuuube commented May 16, 2024

Current UI:

Upon clicking Import Hovering over with mouse Dragging file
image image image

Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the code details very carefully but this looks fine and looks well tested/polished and the breakage risk is low so :shipit:

@jamesmaa jamesmaa added this pull request to the merge queue May 21, 2024
Merged via the queue into yomidevs:master with commit 6301ba6 May 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants