Add word wrap to #extension-info on mobile to prevent page horizontal elongation #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
jamesmaa
reviewed
May 18, 2024
| @@ -496,4 +496,8 @@ select.profile-select { | |||
| width: 100%; | |||
| padding-top: 37.7%; | |||
| } | |||
| #extension-info { | |||
| max-width: 95vw; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Due to the text extending the page itself it isnt possible to use percents here so that's why it's vw.
jamesmaa
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#extension-info is the thing that says "Yomitan v24.5.14.0" or whatever version in the mobile popup (theres some screenshots of this on #886). If the version number is too long (for example v99.99.99.99) this can horizontally extend the action popup page beyond the device's view.
Dev builds of Yomitan also suffer badly from this with the addition of the incredibly long "(development build)" text.
This fix puts "Yomitan" and the version number on different lines if it gets too long.