forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommended dictionaries to welcome page #991
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
be3fa43
Add dictionary import to welcome page
Kuuuube 75b16d7
Initial prototype of recommended dict importing
Kuuuube 10375c1
Disable button immediately
Kuuuube 63b087b
Add queue to allow clicking multiple import buttons at once
Kuuuube b8906c6
Dynamic assignment of recommended dictionaries
Kuuuube e072029
Add to json.json
Kuuuube 12e426d
Merge branch 'master' into welcome-page-dictionary
Kuuuube 94d13bd
Change kanjidic to grab latest release
Kuuuube 8f4927f
Make linter happy
Kuuuube d94ac5e
Add json schema
Kuuuube 0b9e8e6
Add explicit types to dict array properties
Kuuuube 5df34fe
Fix schema $id
Kuuuube 3eb3d95
Change types file to dts and add labeled test type
Kuuuube 6552b7d
Use static jitendex url
Kuuuube 64dc081
Fix url path
Kuuuube c2a4031
Remove BCCWJ-LUW version from name
Kuuuube 5b0f24c
Merge branch 'master' into welcome-page-dictionary
Kuuuube 773ac3e
Only render recommended dictionaries on button click
Kuuuube 6feb4b5
Clean up dictionary rendering
Kuuuube 2bdc15f
Hide dictionaries when going from a language supporting recommended d…
Kuuuube e69f963
Merge branch 'master' into welcome-page-dictionary
Kuuuube 2d8c55d
Update welcome page dict modals
Kuuuube f119f45
Fix spacing
Kuuuube 54797ae
Add back recommended dictionary modals
Kuuuube eab65ad
Fix dictionary importing
Kuuuube a03db48
Remove unneeded progress selectors
Kuuuube 0faa65f
Fix recommended dictionary modal rendering
Kuuuube 812567a
Add pronunciation to recommended dictionary types
Kuuuube 3fdb94c
Fix KANJIDIC name
Kuuuube 706859f
Fix hiding and unhiding of elements
Kuuuube 3816456
Move language select above recommended dictionaries
Kuuuube 2e50478
Use BCCWJ combined instead of BCCWJ-LUW
Kuuuube 5503f0c
show download progress
StefanVukovic99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"ja": { | ||
"terms": [ | ||
{"name": "Jitendex", "url": "https://github.com/stephenmk/stephenmk.github.io/releases/latest/download/jitendex-yomitan.zip"} | ||
], | ||
"kanji": [ | ||
{"name": "KANJIDIC", "url": "https://github.com/themoeway/jmdict-yomitan/releases/latest/download/KANJIDIC_english.zip"} | ||
], | ||
"frequency": [ | ||
{"name": "BCCWJ", "url": "https://github.com/Kuuuube/yomitan-dictionaries/releases/download/yomitan-permalink/BCCWJ_SUW_LUW_combined.zip"} | ||
], | ||
"grammar": [], | ||
"pronunciation": [] | ||
} | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
{ | ||
"$id": "recommendedDictionaries", | ||
Kuuuube marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"description": "Contains data for recommended dictionaries on welcome page.", | ||
"type": "object", | ||
"patternProperties": { | ||
"^.{2,}$": { | ||
"type": "object", | ||
"properties": { | ||
"terms": { | ||
"type": "array", | ||
"items": { | ||
"type": "object", | ||
"required": [ | ||
"name", | ||
"url" | ||
], | ||
"properties": { | ||
"name": { | ||
"type": "string", | ||
"minLength": 2 | ||
}, | ||
"url": { | ||
"type": "string", | ||
"minLength": 2 | ||
} | ||
} | ||
} | ||
}, | ||
"kanji": { | ||
"type": "array", | ||
"items": { | ||
"type": "object", | ||
"required": [ | ||
"name", | ||
"url" | ||
], | ||
"properties": { | ||
"name": { | ||
"type": "string", | ||
"minLength": 2 | ||
}, | ||
"url": { | ||
"type": "string", | ||
"minLength": 2 | ||
} | ||
} | ||
} | ||
}, | ||
"frequency": { | ||
"type": "array", | ||
"items": { | ||
"type": "object", | ||
"required": [ | ||
"name", | ||
"url" | ||
], | ||
"properties": { | ||
"name": { | ||
"type": "string", | ||
"minLength": 2 | ||
}, | ||
"url": { | ||
"type": "string", | ||
"minLength": 2 | ||
} | ||
} | ||
} | ||
}, | ||
"grammar": { | ||
"type": "array", | ||
"items": { | ||
"type": "object", | ||
"required": [ | ||
"name", | ||
"url" | ||
], | ||
"properties": { | ||
"name": { | ||
"type": "string", | ||
"minLength": 2 | ||
}, | ||
"url": { | ||
"type": "string", | ||
"minLength": 2 | ||
} | ||
} | ||
} | ||
}, | ||
"pronunciation": { | ||
"type": "array", | ||
"items": { | ||
"type": "object", | ||
"required": [ | ||
"name", | ||
"url" | ||
], | ||
"properties": { | ||
"name": { | ||
"type": "string", | ||
"minLength": 2 | ||
}, | ||
"url": { | ||
"type": "string", | ||
"minLength": 2 | ||
} | ||
} | ||
} | ||
} | ||
}, | ||
"required": [ | ||
"terms", | ||
"kanji", | ||
"frequency", | ||
"grammar" | ||
], | ||
"additionalProperties": false | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that updating is in, would it take a lot of work to list
index.json
files instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have to ask @StefanVukovic99 on that one. But I think it's probably better to let another pr take that one. And static links will still need to be supported even if we add index.json support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd like that so we can show more info, like the description, but not necessary for now